Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve heartbeat to get better runtimeFramework info. #1094

Closed
cijothomas opened this issue Mar 18, 2019 · 1 comment
Closed

Improve heartbeat to get better runtimeFramework info. #1094

cijothomas opened this issue Mar 18, 2019 · 1 comment

Comments

@cijothomas
Copy link
Contributor

HeartBeat currently uses the following code to get FrameworkVersion, which is not giving any useful information.

#elif NETSTANDARD1_3 || NETSTANDARD2_0
            return System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription;
#else

With the new change in .net core itself, we'll see better information starting 3.0.
dotnet/corefx#35516

We need to do something more useful for non 3.0 customers. Goal is to return something like '.net core2.1' or 'netfw4.7' m for heartbeat field "runtimeFramework".

@github-actions
Copy link

This issue is stale because it has been open 300 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant