Stop using upgrade in terraform init calls
#2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3167341023 (with refid (in response to this comment from @tamirkamara) |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3167580409 (with refid (in response to this comment from @tamirkamara) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2672
What is being addressed
Unmarshal terraform errors in
migrate.sh.This is a result of providers being upgraded and their schema changes. This is usually handled by
terraform applybut we call other commands in the migrate script before the apply which might produce an error.How is this addressed
terraform refreshbefore we callshowto sort out any schema changesrequired_providersblock until recently and some deployments might see providers version move backward when then upgrade to the latest AzureTRE (mostly the random provider).-upgradewhen callingterraform initas that causes an upgrade and disregard the locks file. We don't need that behavior to happen automatically.