Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for GitHub environment variables instead of secrets #3403

Closed
2 tasks
SvenAelterman opened this issue Apr 2, 2023 · 1 comment
Closed
2 tasks

Support for GitHub environment variables instead of secrets #3403

SvenAelterman opened this issue Apr 2, 2023 · 1 comment
Labels
story Stories are the smallest unit of work to be done for a project.

Comments

@SvenAelterman
Copy link
Collaborator

Description

As a TRE Administrator
I want to use GitHub environment variables instead of secrets to store non-sensitive data
So that it's easier to review the configuration of a repo.

I think this list of secrets should be turned into variables instead:

  • TRE_ID
  • LOCATION
  • MGMT_RESOURCE_GROUP_NAME
  • MGMT_STORAGE_ACCOUNT_NAME
  • ACR_NAME
  • CORE_ADDRESS_SPACE
  • TRE_ADDRESS_SPACE
  • TERRAFORM_STATE_CONTAINER_NAME
  • CORE_APP_SERVICE_PLAN_SKU
  • WORKSPACE_APP_SERVICE_PLAN_SKU
  • RESOURCE_PROCESSOR_NUMBER_PROCESSES_PER_INSTANCE
  • ENABLE_SWAGGER

Acceptance criteria

  • CI/CD GitHub Actions (yml) updated to use variables instead of secrets
  • Instructions updated
@SvenAelterman SvenAelterman added the story Stories are the smallest unit of work to be done for a project. label Apr 2, 2023
@tamirkamara
Copy link
Collaborator

Duplicate of #3070

@tamirkamara tamirkamara marked this as a duplicate of #3070 Apr 3, 2023
@tamirkamara tamirkamara closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
story Stories are the smallest unit of work to be done for a project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SvenAelterman @tamirkamara