Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor environment scripts out of Github Actions #3490

Open
2 tasks
tamirkamara opened this issue May 7, 2023 · 0 comments
Open
2 tasks

Refactor environment scripts out of Github Actions #3490

tamirkamara opened this issue May 7, 2023 · 0 comments
Labels
story Stories are the smallest unit of work to be done for a project.

Comments

@tamirkamara
Copy link
Collaborator

tamirkamara commented May 7, 2023 •
edited
Loading

Description

As a TRE Developer
I want to configure computed environment variables inside the dev container / makefile
So that the CICD won't need to compute those values too.

This should be the proper fix for #3488

Acceptance criteria

  • TRE_URL, ARM_ENVIRONMENT are computed inside the devcontainer even when running on Github Actions. Specific steps on action.yml file are removed.
  • Files .github/scripts/construct_tre_url.sh, .github/scripts/convert_azure_env_to_arm_env.sh are removed from the deployment repo.
@tamirkamara tamirkamara added the story Stories are the smallest unit of work to be done for a project. label May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
story Stories are the smallest unit of work to be done for a project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tamirkamara