Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform handles peering sync natively #3534

Merged
merged 6 commits into from
Jun 5, 2023

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

We correctly use AZCLI from within terraform to force network peering sync when there's an address space change.

How is this addressed

  • AzureRM 3.47 improved the ability for Terraform to handle this situation natively. So I've removed the script logic and all associated properties.

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 2d01b08.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5174570172 (with refid a95dfc51)

(in response to this comment from @tamirkamara)

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it works, LGTM!

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5175256020 (with refid a95dfc51)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) June 5, 2023 09:57
@tamirkamara tamirkamara merged commit f6c09d1 into main Jun 5, 2023
@tamirkamara tamirkamara deleted the tamirkamara/workspace-address-space-sync-native branch June 5, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants