Terraform for Service Bus uses deprecated resource type azurerm_servicebus_namespace_network_rule_set

[SvenAelterman]

Describe the bug

When deploying TRE core (e.g., with make deploy-core), I observed this warning from Terraform:

| Warning: Deprecated Resource
│
│ with azurerm_servicebus_namespace_network_rule_set.servicebus_network_rule_set,
│ on servicebus.tf line 78, in resource "azurerm_servicebus_namespace_network_rule_set" "servicebus_network_rule_set":
│ 78: resource "azurerm_servicebus_namespace_network_rule_set" "servicebus_network_rule_set" {
│
│ The azurerm_servicebus_namespace_network_rule_set resource is deprecated and will be removed in version 4.0 of the AzureRM provider. Please use network_rule_set inside the azurerm_servicebus_namespace resource instead.

Azure TRE release version (e.g. v0.14.0 or main): v0.15.2

[marrobi]

seup_local_debugging.sh also needs updating to use network_rule_set...

Line 43:

echo "Adding local IP Address to ${SERVICE_BUS_NAMESPACE}."
if az servicebus namespace network-rule-set list \
  --resource-group "${RESOURCE_GROUP_NAME}" \
  --namespace-name "${SERVICE_BUS_NAMESPACE}" \
  -o json | grep -q "${IPADDR}" ; then
  echo "IP Address ${IPADDR} already exists in ${SERVICE_BUS_NAMESPACE}. Skipping..."
else
  az servicebus namespace network-rule-set ip-rule add \
    --resource-group "${RESOURCE_GROUP_NAME}" \
    --namespace-name "${SERVICE_BUS_NAMESPACE}" \
    --ip-rule ip-address="${IPADDR}" action=Allow
fi