Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactWebChat - defaultProps will be removed #4836

Open
fabricioloupias opened this issue Aug 28, 2023 · 7 comments · May be fixed by #5278
Open

ReactWebChat - defaultProps will be removed #4836

fabricioloupias opened this issue Aug 28, 2023 · 7 comments · May be fixed by #5278
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@fabricioloupias
Copy link

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Latest production

Which distribution are you using Web Chat from?

Bundle (webchat.js)

Which hosting environment does this issue primarily affect?

Web apps

Which browsers and platforms do the issue happened?

No response

Which area does this issue affect?

Development experience

What is the public URL for the website?

No response

Please describe the bug

I am using the react component in version 4.15.9.
I find that I get a lot of alerts like "Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead"
Clearly in future versions of react, defaultProps is going to be removed.

Do you see any errors in console log?

Warning: EventSpy: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

Warning: ConnectivityStatusConnecting: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

How to reproduce the issue?

render

What do you expect?

Release a fix to stop using defaultProps

What actually happened?

Do you have any screenshots or recordings to repro the issue?

image

Adaptive Card JSON

No response

Additional context

No response

@fabricioloupias fabricioloupias added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels Aug 28, 2023
@compulim
Copy link
Contributor

compulim commented Sep 1, 2023

Thanks for letting us know defaultProps will be removed. We will move our defaults into JavaScript default parameters. :)

@compulim
Copy link
Contributor

compulim commented Sep 1, 2023

Note to myself: when working on this, also fix another React warning which only appears when using Web Chat via npm install.

@fabricioloupias
Copy link
Author

any update of this?

@donald-boosted
Copy link

any update?

@niteshpk
Copy link

any updates? in which version we can expect the fix?
Till then do we have any alternative workaround to solve this error?

@ayoussef-insight
Copy link

It's been 11 months and this has not been resolved yet. Do we expect a fix soon?

@steveberdy steveberdy linked a pull request Sep 5, 2024 that will close this issue
@steveberdy
Copy link

I attempted a draft fix of this in #5278. Let me know what you all think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants