Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should abstract datastore be constructed with a distance_fn? Or is this strictly a property of derived classes? #336

Open
yashpatel007 opened this issue Apr 24, 2023 · 1 comment
Open

Should abstract datastore be constructed with a distance_fn? Or is this strictly a property of derived classes? #336

yashpatel007 opened this issue Apr 24, 2023 · 1 comment

Comments

@yashpatel007
Copy link
Contributor 

          Should abstract datastore be constructed with a distance_fn? Or is this strictly a property of derived classes?

Originally posted by @harsha-simhadri in #305 (comment)
@daxpryce
Copy link
Contributor

Is there ever a scenario in which we will have a datastore that has no concept of distance? The way I'm thinking about it, there's no plausible scenario that that exists - which to me implies it should be part of the abstract datastore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daxpryce @yashpatel007