[R-package] Check parameters in cb.reset.parameters()

[jameslamb]

Summary

When passing a list of parameters to cb.reset.parameters(), that function should validate the list that you pass in.

Motivation

Currently, it's possible to use cb.reset.parameters() to sneak bad parameters (e.g. negative num_leaves) into a LightGBM model. Sometimes you might catch this because an error will be thrown elsewhere, but in other cases your code might run but produce incorrect results.

Description

To close this issue, add some code that checks params in cb.reset.parameters() (R-package/R/callback.R). To avoid duplicate code and inconsistencies, it might be valuable to centralize that logic in an internal function like .check_params(params), which then also gets used in lgb.train() and lgb.cv().

References

A centralized parameter-checking function as described in the description section did once exist in the R package (lgb.check.params()) but it was empty. That function was removed in #2652 .

[jameslamb]

Closed in favor of being in #2302. We decided to keep all feature requests in one place.

Welcome to contribute this feature! Please re-open this issue (or post a comment) if you are actively working on implementing this feature.