Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] [ci] Cover 100% of R-to-C++ calls with unit tests #2944

Closed
9 tasks done
jameslamb opened this issue Mar 25, 2020 · 4 comments
Closed
9 tasks done

[R-package] [ci] Cover 100% of R-to-C++ calls with unit tests #2944

jameslamb opened this issue Mar 25, 2020 · 4 comments

Comments

@jameslamb
Copy link
Collaborator

jameslamb commented Mar 25, 2020

LightGBM's R package calls its C++ library using R's .Call() interface. That C++ is one codebase that is reused as a standalone C++ library, with Java, with Spark (via the Java interface), with Python, and from a command-line interface.

Because that library is shared, it's regularly updated by developers who have no knowledge of the lightgbm R package. The R package's unit tests are the best defense against such updates having unintended consequences and breaking the R package.

The following calls to the C++ side from within the R package are not covered by this project's unit tests (this will be updated as tests are added):

I figured that out by following the coverage instructions in the R-package README.

Covering those calls is important because it would improve our confidence in releases and allow non-R developers to work on the C++ library without worrying that their changes are negatively impacting the R package.

This issue will likely not be closed by a single PR. Any PR that addresses some of those functions above would be a welcome addition.

@jameslamb
Copy link
Collaborator Author

Closing this issue in favor of being in #2302 . If you'd like to address this issue, leave a comment here and it will be re-opened.

@jameslamb
Copy link
Collaborator Author

I'm going to open this since we have an open PR for it and I'm working on the other PRs in the next few days

@jameslamb
Copy link
Collaborator Author

All functions have been covered now that we've merged #3020, so this can be closed

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant