You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While the 'engine' tests use the traditional unittest style, where each test case is a method on a class that inherits from unittest.TestCase and conditions are checked with unittest builtin methods.
To close this issue, change all of the tests to the pytest style. You'll know you've been successful if none of the test files need to import unittest.
Motivation
This consistency will make contributing on LightGBM easier. This is especially important in the Python project, which is often used to indirectly test changes at the C++ side (for example, #3299 ).
Description
This change should be applied for all test modules in tests/python_package_test. Please avoid changing any of the test logic and just focus on style.
If you get stuck, @ me here and I can help.
The text was updated successfully, but these errors were encountered:
This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.
Summary
The tests on the Python package currently use two different styles.
The
dask
tests for example, use the pytest style, where each test case is a function and conditions are checked byassert
-ingWhile the 'engine' tests use the traditional unittest style, where each test case is a method on a class that inherits from
unittest.TestCase
and conditions are checked with unittest builtin methods.To close this issue, change all of the tests to the
pytest
style. You'll know you've been successful if none of the test files need toimport unittest
.Motivation
This consistency will make contributing on LightGBM easier. This is especially important in the Python project, which is often used to indirectly test changes at the C++ side (for example, #3299 ).
Description
This change should be applied for all test modules in
tests/python_package_test
. Please avoid changing any of the test logic and just focus on style.If you get stuck,
@
me here and I can help.The text was updated successfully, but these errors were encountered: