Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask] add support for eval sets and custom eval functions #4101

Merged
merged 110 commits into from
Jun 28, 2021
Merged

[dask] add support for eval sets and custom eval functions #4101

Show file tree
Hide file tree
Changes from 107 commits
Commits
Show all changes
110 commits
Select commit Hold shift + click to select a range
08430cb
es WiP, need to add eval_sample_weight and eval_group
ffineis Feb 9, 2021
2b75814
add weight, group to dask es. WiP.
ffineis Feb 11, 2021
77766e9
dask es reorg
ffineis Feb 13, 2021
86341fc
Update python-package/lightgbm/dask.py
ffineis Feb 16, 2021
8d82646
Update tests/python_package_test/test_dask.py
ffineis Feb 16, 2021
69110b4
Update python-package/lightgbm/dask.py
ffineis Feb 16, 2021
69b45dd
Update tests/python_package_test/test_dask.py
ffineis Feb 16, 2021
ee5f157
Update tests/python_package_test/test_dask.py
ffineis Feb 16, 2021
c96be2f
Update python-package/lightgbm/dask.py
ffineis Feb 16, 2021
04040fc
Update python-package/lightgbm/dask.py
ffineis Feb 16, 2021
cf720c9
Update python-package/lightgbm/dask.py
ffineis Feb 16, 2021
c0d8ae6
Update python-package/lightgbm/dask.py
ffineis Feb 16, 2021
5d19b50
Update tests/python_package_test/test_dask.py
ffineis Feb 16, 2021
4421736
Update tests/python_package_test/test_dask.py
ffineis Feb 16, 2021
65f98e5
Update python-package/lightgbm/dask.py
ffineis Feb 16, 2021
6d14586
Update python-package/lightgbm/dask.py
ffineis Feb 16, 2021
6737acd
Update python-package/lightgbm/dask.py
ffineis Feb 16, 2021
7099204
applying changes to eval_set PR WiP
ffineis Feb 16, 2021
18cd42c
dask support for eval_names, eval_metric, eval_stopping_rounds
ffineis Feb 17, 2021
1335591
add evals_result checks and other eval_set attribute-related test che…
ffineis Feb 18, 2021
c67cae5
resolve conflix
ffineis Feb 19, 2021
609d8a0
fix lint errors in test_dask.py
ffineis Feb 19, 2021
0102bc7
drop group_shape from _lgbmmodel_doc_fit.format for non-rankers, add …
ffineis Feb 19, 2021
b03715a
add eval_at to test_dask eval_set ranker tests
ffineis Feb 19, 2021
dfb3c72
add back group_shape to lgbmmmodel docs, tighten tests
ffineis Feb 19, 2021
82cf159
drop random eval weights from early stopping, probably causing traini…
ffineis Feb 20, 2021
8341074
add eval data templates to sklearn fit docs, add eval data docs to dask
ffineis Feb 20, 2021
d232b0b
add n_features to _create_data, eval_set tests stop w/ desirable tree…
ffineis Feb 20, 2021
e56251d
import alphabetically
ffineis Feb 20, 2021
10f6e58
resolve merge conflix
ffineis Feb 23, 2021
96fe750
fix conflix from 3994
ffineis Feb 24, 2021
b9cc723
add back get_worker for eval_set error handling
ffineis Feb 24, 2021
f593fd5
test_dask argmin typo
ffineis Feb 24, 2021
1548559
push forgotten eval_names bugfix
ffineis Feb 25, 2021
22f1ba4
eval_stopping_rounds -> early_stopping_rounds, fix failing non-es test
ffineis Feb 26, 2021
60b709c
change default eval_at to tuple 1-5
ffineis Mar 17, 2021
35f900d
re-drop get_worker
ffineis Mar 21, 2021
7b0c675
drop early stopping support from eval_set commits, move eval_set work…
ffineis Mar 21, 2021
5435fb6
resolve merge conflix w master, fix ova num_trees issue in test_eval_set
ffineis Mar 22, 2021
fe1be20
add eval_class_weight and eval_init_score to lightgbm/dask, WiP
ffineis Mar 23, 2021
ddfc89f
clean up eval_set tests, allow user to specify fewer eval_names, clsw…
ffineis Mar 23, 2021
44776b1
Merge branch 'master' into dask/eval_sets
ffineis Mar 23, 2021
b1cad9a
remove redundant backslash
ffineis Mar 23, 2021
9a97b90
lint fixes
ffineis Mar 24, 2021
3810f24
fix eval_at, eval_metric duplication, let eval_at be Iterable not jus…
ffineis Mar 26, 2021
b11db84
use all data_outputs for test_eval_set tests
ffineis Mar 26, 2021
be09110
undo newlines from first pr
ffineis Apr 2, 2021
f9f1fc2
add custom_eval_metric test, correct issue with eval_at and metric names
ffineis Apr 2, 2021
4802295
move _constant_metric outside of test
ffineis Apr 3, 2021
2cb6973
dataset reference names instead of __strings__
ffineis Apr 3, 2021
c1f6e00
add padding to eval_set parts makes each part has same len(eval_set)
ffineis Apr 6, 2021
38f8693
eval set code clean up
ffineis Apr 6, 2021
efc5dab
merge master resolve conflix
ffineis Apr 7, 2021
6c3ea9b
revert n_evals to be max len eval_set across all parts on worker
ffineis Apr 7, 2021
1eb0187
pylint errors in _DatasetNames
ffineis Apr 7, 2021
1032570
more pylint fixes
ffineis Apr 7, 2021
c46b8cb
pylinting...
ffineis Apr 7, 2021
c0cb0dd
add by pytest.mark, mistakenly deleted during merge conflict resolution
ffineis Apr 7, 2021
cdade56
Merge branch 'master' into dask/eval_sets
ffineis Apr 19, 2021
9f3700a
address code review comments
ffineis Apr 21, 2021
d8c5353
merge master
ffineis Apr 21, 2021
a55c61a
Merge branch 'master' into dask/eval_sets
ffineis Apr 22, 2021
7bf7136
add _pad_eval_names to handle nondeterministic evals_result_ valid se…
ffineis Apr 23, 2021
98a407f
change not evaluated evals_result_ test criteria
ffineis Apr 23, 2021
ce9de34
address fit eval docs issues, switch _DatasetNames to Enum
ffineis Jun 1, 2021
e726d2c
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
49a3f0e
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
88f3e00
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
cbcf140
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
0bad066
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
71eb182
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
b4c3f8a
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
fd08c0d
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
901e99a
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
584b15b
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
af86d05
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
d95e392
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
70c8e88
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
3a7277f
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
da1439e
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
39d12c2
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
2995197
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
70761f1
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
ced1b85
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
c18aff4
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
b257675
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
8db8015
Update python-package/lightgbm/dask.py
ffineis Jun 1, 2021
e6b104e
Merge branch 'dask/eval_sets' of https://github.com/ffineis/LightGBM …
ffineis Jun 1, 2021
6cfc281
update eval_metrics, eval_at dask fit docstr to match sklearn, make t…
ffineis Jun 4, 2021
ee3f8b8
Merge branch 'master' into dask/eval_sets
ffineis Jun 4, 2021
9cdbb1f
address eval_set dict keys naming in docstr and training eval_set nam…
ffineis Jun 6, 2021
01206f6
in test_dask check for obj-default metric names in eval_results, remo…
ffineis Jun 6, 2021
fca3a2a
Merge branch 'master' into dask/eval_sets
ffineis Jun 6, 2021
ec0f095
lint fixes for _pad_eval_names
ffineis Jun 6, 2021
9d7c3f0
remove unnecessary breaklinen in _pad_eval_names docstr
ffineis Jun 14, 2021
e742f18
use Enum.member syntax not Enum.member.name
ffineis Jun 14, 2021
d6896d8
remove str from supported eval_at types
ffineis Jun 14, 2021
6b2fa52
add whitespace and remove DaskDataframes mention from eval_ param doc…
ffineis Jun 14, 2021
e879b6d
remove "of shape = [n_samples]" from group_shape docs
ffineis Jun 14, 2021
0195951
add eval_at base_doc in DaskLGBMRanker.fit
ffineis Jun 14, 2021
259f3ec
remove excess paren from eval_names docs in _train
ffineis Jun 14, 2021
2462cfe
merge fixes from 4375
ffineis Jun 17, 2021
703e6f7
make requested changes to test_dask.py
ffineis Jun 17, 2021
6da34f6
remove Optional() wrapper on eval_at
ffineis Jun 19, 2021
97c1bf2
Merge branch 'master' into dask/eval_sets
ffineis Jun 21, 2021
5d4ddc8
add _lgbmmodel_doc_custom_eval_note to dask.py fit.__doc__
ffineis Jun 21, 2021
028727e
fix ordering of .sklearn imports to attempt lint fix
ffineis Jun 21, 2021
7d36e22
dask custom eval note to f-string pt1
ffineis Jun 23, 2021
e493362
dask custom eval note to f-string pt 2
ffineis Jun 23, 2021
efb1825
dask custom eval note to f-string pt 3
ffineis Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading