New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor Parameter out of Instrument #42

Closed

alexcjohnson opened this issue Feb 23, 2016 · 1 comment

Contributor

alexcjohnson commented Feb 23, 2016

from @AdriaanRol discussion in #38

I noticed that the parameter class is located inside the instrument folder. Previously this made sense but I think that in recent PRs #39 and #40 we have made the notion of a parameter more abstract and indepenent of the instrument. Would it make sense to separate/refactor this?

Yes, yes it would make sense

alexcjohnson mentioned this issue

Merged

alexcjohnson mentioned this issue

optional arguments to Functions #51

Closed

Contributor

giulioungaretti commented Dec 9, 2016

Possibly to be fixed in. #403 !

giulioungaretti closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment