Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zstd tuning #248

Closed
s0l0ist opened this issue Dec 4, 2020 · 4 comments
Closed

Zstd tuning #248

s0l0ist opened this issue Dec 4, 2020 · 4 comments

Comments

@s0l0ist
Copy link
Contributor

s0l0ist commented Dec 4, 2020

First, great work with the latest release. Using SEAL with the default zstd compression level dramatically increases performance; however I've noticed much higher levels of memory consumption during serialization.

I can choose the zlib override at runtime to avoid the memory issues, but of course the performance suffers.

Are there any plans for exposing zstd options at runtime?

@kimlaine
Copy link
Contributor

kimlaine commented Dec 4, 2020

That would certainly be possible. It's really easy now to add support for other compr_mode_types. For example, one could be zstd_mem_opt (memory optimized), and another could be zstd_perf_opt. Alternatively, maybe one particular setting is just much better (insignificant reduction in performance and significant improvement in memory cost) and we could only use that. I'm not familiar at all with tuning Zstandard, but if someone else is maybe they could recommend specific settings. In any case, I'll add this to the to-do list.

@kimlaine
Copy link
Contributor

kimlaine commented Dec 8, 2020

This is not actually about Zstandard; I looked into this more after another issue was reported. Turns out there was a bug in SEAL that caused a huge number of memory allocations of increasing size when using ZSTD compression.

We'll be releasing v3.6.1 shortly to fix this issue.

@s0l0ist
Copy link
Contributor Author

s0l0ist commented Dec 8, 2020

Yes, that is exactly the same issue. Thanks @kimlaine!

@kimlaine
Copy link
Contributor

kimlaine commented Dec 8, 2020

3.6.1 is now available. Please let us know if there are further issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants