Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VSO comments to GitHub issues #2271

Open
Tracked by #4699
AlexGuteniev opened this issue Oct 12, 2021 · 0 comments
Open
Tracked by #4699

Change VSO comments to GitHub issues #2271

AlexGuteniev opened this issue Oct 12, 2021 · 0 comments
Labels
meta Issues about issues!

Comments

@AlexGuteniev
Copy link
Contributor

I think it should be a part of GitHub migration to migrate all VSO issues; but I think the ones mentioned in TRANSITION comments should be prioritized, and corresponding comments should be updated.

If some issue should not be migrated, probably a short description in TRANSITION comment should be added.

An example I've encountered today:

STL/stl/inc/xmemory

Lines 68 to 71 in 8833270

template <class _Ty>
_INLINE_VAR constexpr size_t _New_alignof = (_STD max) (alignof(_Ty),
static_cast<size_t>(__STDCPP_DEFAULT_NEW_ALIGNMENT__) // TRANSITION, VSO-522105
);

I think I want to understand what exactly TRANSITION means here.

@CaseyCarter CaseyCarter added decision needed We need to choose something before working on this meta Issues about issues! labels Oct 13, 2021
@StephanTLavavej StephanTLavavej removed the decision needed We need to choose something before working on this label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues about issues!
Projects
None yet
Development

No branches or pull requests

3 participants