Highlighting fails when generic type declaration spans many lines

[mjbvz]

TS and JS Grammar Extension version: 0.0.22 / latest

From microsoft/vscode#29135

Code

Using the typescript react gammar:

const connectedComponent = connect<
	ApplicationState,
	Dispatch<TodoAction>,
	HomeComponent
>(mapStateToProps, mapDispatchToProps)(Home);

Elements after Dispatch< are marked as a tsx component and not highlighted properly:

[sheetalkamat]

This is by design as the grammar lookup doesn't allow multiple lines at a time. Hence at location connect < cannot be determined as type parameter.

[vjeux]

JSX doesn't allow any [a-z] character before the < for the outer one, so Dispatch<TodoAction> cannot be a JSX element. Is there a way to encode this inside of the TmLanguage format?

[sheetalkamat]

But the < could be less than operator.

[vjeux]

That's true but I don't really understand why it's an issue here. In this case, <TodoAction> is being recognized as a JSX element. In the JSX element detection, could you ensure that the previous character is not [a-zA-Z_$]?

[sheetalkamat]

@vjeux yes that can be done, but please open another issue with valid code that is broken. Thanks