-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript doc visible for aliased imports, but not for single ones. #11099
Comments
From @chrmarti on September 21, 2016 16:42 Can reproduce with the given example and TypeScript 1.8 in todays insider build. |
Repro'd with latest TypeScript release bits - release-2.0.5 branch. Here is code to copy and paste. test.ts import { MyClass } from './myModule';
MyClass // When hovering MyClass, the written doc is not visible.
import * as myModule from './myModule';
myModule.MyClass // When hovering MyClass, the written doc appears. myModule.ts /**
* Some documentation
*/
export class MyClass {
} sending to TypeScript language service repo. |
This is currently a huge painpoint. Improving this would be a very big win. |
I'd also like to point out that default imports don't get the (js)doc for that export either. import SomeDefaultExport from './FooBar'; Hovering over I'm not at my desktop at the moment, so I haven't tested this, but imagine the same problem would exist with imports like this: import { Foo as Bar } from './FooBar'; I'll update this post when I'm able to test that. My experience with this bug are in Editthe same issues also appears with JavaScript. import { Foo as Bar } from './FooBar'; |
I've lost quite some time thinking I was doing type exports / imports wrong due to not seeing the docs on hover. 😅 What's the status on this? Waiting for someone from the community to work on it? |
I'm the one who reported microsoft/vscode#28753. You can see the repro easily there. This seems like something basic that should just work, especially considering that props work fine (and that seems like it'd be harder to support). :D But anyways, please fix/include the class/component-level docs inclusion soon! |
Is this a duplicate of #5515? |
The reported code works OK today - the documentation is displayed. cc @jakebailey |
From @Elarcis on September 21, 2016 7:35
Steps to Reproduce:
myClass.ts
file exporting aMyClass
class. Write some/** */
doc for that class.It seems logical that the doc should appear in both cases, is this due to Typescript 2?
Copied from original issue: microsoft/vscode#12360
The text was updated successfully, but these errors were encountered: