Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completions for locals should have higher "sortOrder" than completions for globals #18398

Closed
mjbvz opened this issue Sep 11, 2017 · 2 comments
Closed
Labels
Duplicate An existing issue was already created

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Sep 11, 2017

From microsoft/vscode#34049

TypeScript Version: 2.5.2

Code

const WorkerActions = 1

WA|

Trigger completions at the | after WA

Expected behavior:
The local WorkerActions suggestion has higher weight than suggestions from the global scope.

Actual behavior:
TSServer returns global and local suggestions with the same sortText

[Trace  - 3:27:09 PM] Sending request: completions (353). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "/Users/matb/projects/san/d.js",
    "line": 3,
    "offset": 3
}
[Trace  - 3:27:09 PM] Response received: completions (353). Request took 19 ms. Success: true 
Result: [
   ....
       {
        "name": "WaveShaperNode",
        "kind": "interface",
        "kindModifiers": "declare",
        "sortText": "0"
    },
    {
        "name": "WorkerActions",
        "kind": "const",
        "kindModifiers": "",
        "sortText": "0"
    },
 ...
]
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Sep 11, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Sep 12, 2017

Seems like a duplicate of #15024

@mhegazy mhegazy added Duplicate An existing issue was already created and removed VS Code Tracked There is a VS Code equivalent to this issue labels Sep 12, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Sep 26, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed Sep 26, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants