Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninitialized readonly property is not reported #18667

Closed
dobrakmato opened this issue Sep 21, 2017 · 2 comments
Closed

Uninitialized readonly property is not reported #18667

dobrakmato opened this issue Sep 21, 2017 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@dobrakmato
Copy link

TypeScript Version: 2.5.2

Code

class Connection {
    public query(sql) {
        return null;
    }
}

class Database {
    private readonly property: string = 'This is initialized';
    private readonly thisToo: number;
    private readonly connection: Connection;

    constructor() {
        this.thisToo = 42;
    }

    public importantMethod() {
        return this.connection.query('SELECT * FROM users');
    }
}

Expected behavior:
I expect the property connection to be reported as "Not initialized read-only property" error because it is

  1. not initialized in constructor
  2. also marked as readonly so it can't be initialized anywhere else.

Actual behavior:
Compiler generates broken / not working code.

var Database = /** @class */ (function () {
    function Database() {
        this.property = 'This is initialized';
        this.thisToo = 42;
    }
    Database.prototype.importantMethod = function () {
        return this.connection.query('SELECT * FROM users');
    };
    return Database;
}());
@mhegazy
Copy link
Contributor

mhegazy commented Sep 21, 2017

This should be done along with #8476. basically same analysis required in both cases.

@mhegazy mhegazy added the Duplicate An existing issue was already created label Sep 21, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Oct 6, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed Oct 6, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants