Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for validity of all generated *.d.ts in bin #2269

Closed
mihailik opened this issue Mar 9, 2015 · 3 comments
Closed

Tests for validity of all generated *.d.ts in bin #2269

mihailik opened this issue Mar 9, 2015 · 3 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this

Comments

@mihailik
Copy link
Contributor

mihailik commented Mar 9, 2015

Generated declaration files should at least be compilable with no errors (see issue #2268 for example).

The simplest pragmatic way is to run compiler on a dummy TS file and a corresponding file.d.ts. If it doesn't crash, it's a pass.

@danquirk
Copy link
Member

Could call this a suggestion but I think it's just a bug that we're not doing this kind of validation.

@mhegazy
Copy link
Contributor

mhegazy commented Mar 10, 2015

We already have a test for typescript.d.ts see https://github.com/Microsoft/TypeScript/blob/master/tests/cases/compiler/APISample_compile.ts

@mihailik feel free to add a test for typescript_internal as well.

@mhegazy mhegazy added the Help Wanted You can do this label Mar 10, 2015
@mhegazy mhegazy added this to the Community milestone Mar 10, 2015
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Apr 11, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Apr 11, 2015

PR #2692 removes the _internal files.

@mhegazy mhegazy closed this as completed Apr 11, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

3 participants