Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Imports doesnt order underscores the same as tslint #25690

Closed
mjbvz opened this issue Jul 16, 2018 · 1 comment
Closed

Organize Imports doesnt order underscores the same as tslint #25690

mjbvz opened this issue Jul 16, 2018 · 1 comment
Labels
Duplicate An existing issue was already created

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jul 16, 2018

From @Slessi on July 16, 2018 13:43

  • VSCode Version: 1.25.1
  • OS Version: macOS High Sierra 10.13.5

Steps to Reproduce:

Organizing generates the below:

import {
  EmployeeLeave,
  EmployeeLeave as EmployeeLeaveResponse,
  EmployeeLeaveResponses,
  EmployeeLeaveVariables,
  EmployeeLeave_employeeLeave,
  EmployeeLeave_pendingEmployeeLeave,
} from '../GraphQL/types';

However, tslint expects the following order:

Note: Don't understand why, but if you have as underscores are ordered last, but if you do not have as, underscores are ordered first?

import {
  EmployeeLeave,
  EmployeeLeave as EmployeeLeaveResponse,
  EmployeeLeave_employeeLeave,
  EmployeeLeave_pendingEmployeeLeave,
  EmployeeLeaveResponses,
  EmployeeLeaveVariables,
} from '../GraphQL/types';

Does this issue occur when all extensions are disabled?: Yes

Copied from original issue: microsoft/vscode#54393

@mjbvz mjbvz self-assigned this Jul 16, 2018
@mjbvz mjbvz added VS Code Tracked There is a VS Code equivalent to this issue and removed typescript labels Jul 16, 2018
@mjbvz mjbvz removed their assignment Jul 16, 2018
@mhegazy mhegazy added Suggestion An idea for TypeScript Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Domain: Organize Imports Issues with the organize imports feature labels Jul 16, 2018
@j-oliveras
Copy link
Contributor

j-oliveras commented Jul 16, 2018

Duplicate of #25114.

@mhegazy mhegazy added Duplicate An existing issue was already created and removed Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Domain: Organize Imports Issues with the organize imports feature Suggestion An idea for TypeScript VS Code Tracked There is a VS Code equivalent to this issue labels Jul 16, 2018
@mhegazy mhegazy closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants