Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SymbolFlags.TypeAlias when binding a jsdoc enum instead of SymbolFlags.Enum #32413

Closed
weswigham opened this issue Jul 15, 2019 · 0 comments · Fixed by #32520
Closed

Use SymbolFlags.TypeAlias when binding a jsdoc enum instead of SymbolFlags.Enum #32413

weswigham opened this issue Jul 15, 2019 · 0 comments · Fixed by #32520
Labels
Domain: JSDoc Relates to JSDoc parsing and type generation Infrastructure Issue relates to TypeScript team infrastructure

Comments

@weswigham
Copy link
Member

While working on #32372 I realized something - While the jsdoc tag is called @enum, behaviorally it does nothing like what a TS enum would do and does everything that a type alias would do (it is really like an @typedef with some extra checks). We should be able to remove heaps of special case code just by changing the flag we bind with and the associated declaration types.

@weswigham weswigham added Infrastructure Issue relates to TypeScript team infrastructure Domain: JSDoc Relates to JSDoc parsing and type generation labels Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: JSDoc Relates to JSDoc parsing and type generation Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant