Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iterator in NodeList interface #3381

Closed
saschanaz opened this issue Jun 4, 2015 · 6 comments
Closed

Add iterator in NodeList interface #3381

saschanaz opened this issue Jun 4, 2015 · 6 comments
Labels
Duplicate An existing issue was already created

Comments

@saschanaz
Copy link
Contributor

Would you please add iterator in NodeList interface as DOM4 spec says?

IDL[Exposed=Window]
interface NodeList# {
  getter Node? item(unsigned long index#);
  readonly attribute unsigned long length;
  iterable<Node>;
};
NodeList.prototype[Symbol.iterator]
// gives `function [Symbol.iterator]()` in Firefox console
@mhegazy
Copy link
Contributor

mhegazy commented Jun 4, 2015

looks like duplicate of #2695

@mhegazy mhegazy added the Duplicate An existing issue was already created label Jun 4, 2015
@saschanaz
Copy link
Contributor Author

Oh, it really is. Sorry.

@mhegazy
Copy link
Contributor

mhegazy commented Jun 4, 2015

We would take a PR if you are interested.

@saschanaz
Copy link
Contributor Author

Okay, I'll do some study to add tests before sending a PR.

@mhegazy
Copy link
Contributor

mhegazy commented Jun 4, 2015

as @Arnavion mentions in #2695 (comment), we need to have this as an extension in a separate file, so that it is included in lib.es6.d.ts but not in lib.d.ts. feel free to ping me if you have any questions.

@saschanaz
Copy link
Contributor Author

lib.dom.es6.d.ts. I see :)

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants