Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow template string index signatures #43136

Closed
5 tasks done
cherryblossom000 opened this issue Mar 8, 2021 · 2 comments
Closed
5 tasks done

Allow template string index signatures #43136

cherryblossom000 opened this issue Mar 8, 2021 · 2 comments

Comments

@cherryblossom000
Copy link
Contributor

Suggestion

πŸ” Search Terms

template string index signature number bigint

βœ… Viability Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Currently, only strings or numbers can be used as index signatures. Until template strings were added, mapped types could work around this:

// this won't work:
// type Foo = {[x: 'foo' | 'bar']: number}

// this does:
type Foo = {[K in 'foo' | 'bar']: number} // or alternatively Record<'foo' | 'bar', number>

However, when attempting to use mapped types for template string types, the type becomes {}:

type TemplateString = `${number}: ${string}`
// DoesntWork is {}
type DoesntWork = Record<TemplateString, number>

πŸ“ƒ Motivating Example

Say you had a UUID type:

type UUID = `${string}-${string}-${string}-${string}-${string}`

This feature would allow more type-safe index signatures (instead of simply Record<UUID, User>, for example):

interface User {
  username: string
  // ...
}

const users: Record<UUID, User>

users['01234567-89ab-cdef-0123-456789abcdef'] = {username: 'Alice'}

// Compile error
users['invalid'] = {username: 'Bob'}

// Compile error
const someUser = users['invalid']

I'll change this example if I or anyone else comes up with a better one.

πŸ’» Use Cases

Discord uses snowflakes, which are 64-bit integers, for IDs. The package discord-api-types exports this:

export type Snowflake = `${bigint}`

My use case is that I want to have a Record<Snowflake, SomeType>, but I was a little surprised and disappointed when that turned out to be {}.

An alternative that would fix my specific use case would be to allow bigints in index signatures, but in my opinion that would be confusing as property keys are converted to strings anyway. I believe allowing template strings in index signatures is a more general solution that could be helpful in many use cases.

@MartinJohns
Copy link
Contributor

See #26797. It's on the roadmap for 4.3 as "Generalized index signatures".

@cherryblossom000
Copy link
Contributor Author

Sorry, I didn't realise template string types were a part of that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants