-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute incorrectly added for opening JSX tag #47090
Comments
@armanio123 @RyanCavanaugh This looks like a potential candidate for the TS recovery build. Even when you set |
@mjbvz good catch, this is annoying as heck |
namespace JSX {
export interface IntrinsicElements {
button: any;
div: any;
}
}
function fn() {
return <>
<butto
</>;
} Bring up completion and tab-complete at
when it should be (as was in 4.4)
|
I can't reproduce that bit; are you in a In any case, I've sent #47096; what was happening was that in this broken AST, it looks like an attribute, when in fact it's the tag name. 4.4 didn't have JSX attribute snippets, so never had to care about this detail. |
Thanks for taking a look @jakebailey! The VS Code recovery build will go our Tuesday. Would it be possible to get this into a published TS 4.5.4 by then? |
Yes, I think we can do a cherry-pick/build. |
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
The text was updated successfully, but these errors were encountered: