Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salsa Feedback #7854

Closed
bowdenk7 opened this issue Apr 6, 2016 · 11 comments
Closed

Salsa Feedback #7854

bowdenk7 opened this issue Apr 6, 2016 · 11 comments
Labels
Discussion Issues which may not have code impact

Comments

@bowdenk7
Copy link

bowdenk7 commented Apr 6, 2016

This issue can be used for general feedback on the new JavaScript language service Salsa. If you feel like something is a bug, file a separate issue, but for general discussion and feedback just comment below. We will spin off new topic or feature request issues as needed.

@bowdenk7 bowdenk7 added Salsa Discussion Issues which may not have code impact labels Apr 6, 2016
@iwaldman
Copy link

emmet support within JSX

@mhegazy
Copy link
Contributor

mhegazy commented Apr 11, 2016

emmet support within JSX

@iwaldman can you elaborate?

@DanielRosenwasser
Copy link
Member

Emmet (see #4835 (comment) and #6508 (comment)), is a macro system for HTML-like languages that works as you type. VS Code has support for it as far as I know (microsoft/vscode#732).

@mhegazy
Copy link
Contributor

mhegazy commented Apr 13, 2016

Emmet (see #4835 (comment) and #6508 (comment)), is a macro system for HTML-like languages that works as you type. VS Code has support for it as far as I know (microsoft/vscode#732).

I understand, i was more interested in what the request was, is it to develop an emmet like system for TS? just JSX? why not just use emmet?

@aersam
Copy link

aersam commented Jun 3, 2016

In TypeScript we do have namespaces. In JavaScript there are idioms for this. I sometimes write something like this:

// Create a namespace "memDb.controllers"
window.memDb = window.memDb || {};
memDb.controllers = memDb.controllers || {};

memDb.controllers.AClass = class { 
 // ...
};

Should something like this be supported by Salsa? How to do namespaces in Salsa?

@mhegazy
Copy link
Contributor

mhegazy commented Jun 4, 2016

@aersamkull this is tracked by #7632

@chicoxyzzy
Copy link
Contributor

chicoxyzzy commented Jun 14, 2016

Are language extensions (analogues to babel plugins) planned in Salsa? It'll be cool if we'll be able to throw out Babel which is used mainly for React optimisations (1, 2) (BTW these two might be in core of TS) and code instrumentation.

@AbraaoAlves
Copy link

Salsa could be used to generate definition files from js, like Typescirpt does from ts. There are any plans for this?

@aluanhaddad
Copy link
Contributor

@AbraaoAlves #7546 tracks that. It would be super useful.

@MystK
Copy link

MystK commented Jan 31, 2017

Would be great to have AMD module support! 👍 :)

@mhegazy
Copy link
Contributor

mhegazy commented Nov 28, 2017

Looks like we have issues tracking most of the suggestions here. Please file new issues as needed. Closing this issue for housekeeping purposes.

@mhegazy mhegazy closed this as completed Nov 28, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Discussion Issues which may not have code impact
Projects
None yet
Development

No branches or pull requests

9 participants