Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move class property transform #31848

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Move class property transform #31848

merged 2 commits into from
Jun 17, 2019

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented Jun 10, 2019

This PR is an updated version of #30467, which moves the class property transform to a separate transformation phase.

Fixes #31792
Fixes #31850
Supersedes #30467

@rbuckton rbuckton requested a review from weswigham June 10, 2019 19:44
@rbuckton
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 10, 2019

Heya @rbuckton, I've started to run the extended test suite on this PR at 5bd3402. You can monitor the build here. It should now contribute to this PR's status checks.

@rbuckton rbuckton force-pushed the move-class-property-transform branch from 5bd3402 to 1479823 Compare June 10, 2019 20:32
@rbuckton
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 10, 2019

Heya @rbuckton, I've started to run the extended test suite on this PR at 1479823. You can monitor the build here. It should now contribute to this PR's status checks.

@rbuckton rbuckton merged commit 1793813 into master Jun 17, 2019
@rbuckton rbuckton deleted the move-class-property-transform branch June 17, 2019 21:27
@robpalme robpalme mentioned this pull request Jun 18, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing a regression test for a bug Emitting type parameters (regression)
3 participants