Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib/es2019): Symbol.description may be undefined #36263

Merged

Conversation

ExE-Boss
Copy link
Contributor

The Symbol.prototype.description getter may return undefined, because the constructor allows undefined descriptions.

@DanielRosenwasser
Copy link
Member

@typescript-bot test this
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 21, 2020

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at 5aafd26. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 21, 2020

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 5aafd26. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ExE-Boss ExE-Boss requested a review from andrewbranch January 23, 2020 23:46
@RyanCavanaugh RyanCavanaugh merged commit 6f0c641 into microsoft:master Jan 24, 2020
@RyanCavanaugh
Copy link
Member

Thanks!

@ExE-Boss ExE-Boss deleted the lib/es2019/fix-symbol-description branch January 24, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants