-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emoji support to Windows Console #590
Comments
Come on; at least give us GPU support first. |
@bitcrazed |
@be5invis Rewrite? Only the parts that desperately need it. Otherwise, we're re-architecting and modularizing much of the Console internals which will result in us being able to iterate FAR faster, and more confidently & safely. |
Make console great again. |
Is there any progress in supporting emoji ? |
@fcharlie This is very hard, the entire console buffer is a fixed data structure that each cell has only 16 bits. |
@fcharlie And it has C++ interfaces... |
@be5invis I use WriteConsoleW output emoji ❤️ ,mybe use DirectWrite can output more Emoji |
Not entirely sure on the internals, but it should be possible to affect only the rendering, without changing the underlying memory structure. (Even if the character spacing becomes "off" with emoji taking up the space of two regular characters, that would be a fine compromise) |
Sure ... if you're starting from scratch, you might chose some flexible encoding like UTF-8 (though that has it's own perf costs to consider), but doesn't help you when the Console's internal buffers are currently UCS-2 based and can't fully deal with Unicode scenarios including zero-width joiners, and surrogate pairs. And in amongst the work to handle Unicode encodings that we don't currently support (e.g. UTF-8), we have to modularize and wrap the internal buffers, expose an API that the rest of the Console is modified to call, rather than allowing external code to delve into the data structures and directly manipulate memory in a somewhat haphazard manner! |
I hate to be that guy, but have there been any updates to this? |
@HotelCalifornia - You are now, officially, THAT guy ;) :D While we've not moved forward on this feature of late, we HAVE completed a ton of stuff & this ask is edging up the backlog. A few more things to get to yet, but it's getting closer. Bear with us! |
@bitcrazed thanks for the honest update. Does that mean UTF-8 is also on the way? |
Absolutely. UTF-8 support is a pre-req' for us to eventually support emoji, and many other complex languages, symbols, etc. |
Thanks for the discussion. Closing this issue since:
If you have further asks/issues, please file new issues on our Console GitHub Repo. |
Ok @bitcrazed Go here: microsoft/terminal#190 |
None of these options are working for me. When I try to run any variant of Error: Oxffffffff |
Sorry @lc5415 - this is the Terminal repo, and a closed issue discussing emoji support. If you're having WSL issues, could you please file an issue on the WSL repo: https://github.com/microsoft/wsl. Thanks. |
Excuse me @bitcrazed I got the issue number wrong! |
No problem ... I've done this countless times myself ;) |
Windows Console does not support emoji and other extended character-sets, as reported by the emoj team: sindresorhus/emoj#5 (comment)
Consider adding emoji support to Windows Console in the future
The text was updated successfully, but these errors were encountered: