Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insider reflow validation: Overview test details column lines overlap/misalign at certain zoom level/window width #3082

Closed
lisli1 opened this issue Jul 15, 2020 · 4 comments
Closed

Insider reflow validation: Overview test details column lines overlap/misalign at certain zoom level/window width #3082

lisli1 opened this issue Jul 15, 2020 · 4 comments
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.

Comments

@lisli1
Copy link
Contributor

lisli1 commented Jul 15, 2020 •
edited
Loading

Describe the bug

At a certain zoom level or window width, the lines in the test details columns overlap or misalign.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Accessible University
  2. Run an Assessment
  3. Zoom or resize details view window, while keeping Test details in view
  4. See overlapping/misaligned lines

overview-test-details-bug

CodePen repro example

Expected behavior

The lines should not overlap and should be aligned when there are two columns.

Screenshots

Screenshot of overlapping lines
image

Screenshot of misaligned lines
image

Context (please complete the following information)

Are you willing to submit a PR?

yes

Did you search for similar existing issues?

no

Additional context
@lisli1 lisli1 added the bug Something isn't working label Jul 15, 2020
@msft-github-bot msft-github-bot added the status: new This issue is new and requires triage by DRI. label Jul 15, 2020
@jalkire jalkire added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Jul 15, 2020
@msft-github-bot
Copy link
Collaborator

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@msft-github-bot msft-github-bot removed the status: new This issue is new and requires triage by DRI. label Jul 15, 2020
@jalkire jalkire removed their assignment Jul 15, 2020
@ferBonnin
Copy link
Contributor

per conversation with Peter, marking as ready for work

@ferBonnin ferBonnin added the status: ready for work This issue is ready to be worked on. label Jul 20, 2020
@msft-github-bot msft-github-bot removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Jul 20, 2020
@ferBonnin ferBonnin removed their assignment Jul 20, 2020
@waabid waabid self-assigned this Jul 23, 2020
@ferBonnin ferBonnin added the status: active This issue is currently being worked on by someone. label Jul 23, 2020
@msft-github-bot msft-github-bot removed the status: ready for work This issue is ready to be worked on. label Jul 23, 2020
@waabid waabid mentioned this issue Jul 29, 2020
Merged
7 tasks
@waabid waabid added status: resolved This issue has been merged into main and deployed to canary. and removed status: active This issue is currently being worked on by someone. labels Aug 3, 2020
@ferBonnin
Copy link
Contributor

@lisli1 can you please verify the fix?

@lisli1
Copy link
Contributor Author

lisli1 commented Aug 11, 2020

LGTM in Canary 2020.8.11.1635

@lisli1 lisli1 closed this as completed Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jalkire @ferBonnin @waabid @msft-github-bot @lisli1