Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in test. #3994

Closed
Bram-diederik opened this issue Mar 2, 2021 · 11 comments
Closed

Typo in test. #3994

Bram-diederik opened this issue Mar 2, 2021 · 11 comments
Labels
bug Something isn't working status: needs author feedback This issue requires additional information from the issue author. status: no recent activity This issue requires additional information from the author, but hasn't been updated recently. status: resolved This issue has been merged into main and deployed to canary.

Comments

@Bram-diederik
Copy link

There are tests added. I think this line has a typo:
Select-name: Select element must have and accessible name.

btw the associated tests are all written plural instead of singular

image
@Bram-diederik Bram-diederik added the bug Something isn't working label Mar 2, 2021
@ghost ghost added the status: new This issue is new and requires triage by DRI. label Mar 2, 2021
@ghost ghost assigned jalkire Mar 2, 2021
@jalkire jalkire added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Mar 2, 2021
@ghost ghost assigned ferBonnin Mar 2, 2021
@ghost
Copy link

ghost commented Mar 2, 2021

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@ghost ghost removed the status: new This issue is new and requires triage by DRI. label Mar 2, 2021
@jalkire jalkire removed their assignment Mar 2, 2021
@ferBonnin
Copy link
Contributor

Making a few notes to aid triaging: The rule name and short description are from axe-core directly, there are a few cases where they refer to things as singular instead of plural although looks like mostly on the cases where its expected to have a single element (skip-link, main landmark, lang)

@ferBonnin
Copy link
Contributor

Per conversation with Peter the typo comes directly from axe-core.
@dbjorge can we file a bug (or a PR) on axe-core directly, please? the text should say must have an instead of must have and and the comment on singular vs plural is also interesting to note

@ferBonnin ferBonnin added the status: ready for work This issue is ready to be worked on. label Mar 8, 2021
@ghost ghost removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Mar 8, 2021
@dbjorge
Copy link
Contributor

dbjorge commented Mar 9, 2021

@ferBonnin This was already fixed in axe-core in December (dequelabs/axe-core#2676) and has been included in axe-core since v4.1.2 (we're currently on v4.1.1). We expect to pick up this fix in our next web release after we pick up the new axe-core update.

@ferBonnin
Copy link
Contributor

@ferBonnin This was already fixed in axe-core in December (dequelabs/axe-core#2676) and has been included in axe-core since v4.1.2 (we're currently on v4.1.1). We expect to pick up this fix in our next web release after we pick up the new axe-core update.

Thanks @dbjorge!

@ferBonnin
Copy link
Contributor

this will get addressed with feature work. @ferBonnin to tag to the right feature

@codeofdusk
Copy link
Contributor

I think this might've been resolved with #4155 (4.2.0 is newer than 4.1.2).

@ferBonnin
Copy link
Contributor

Hi @Bram-diederik this has been addressed with the latest release of Accessibility Insights for Web updating to axe-core 4.2!

@ferBonnin ferBonnin added the status: resolved This issue has been merged into main and deployed to canary. label Apr 30, 2021
@ghost ghost removed the status: ready for work This issue is ready to be worked on. label Apr 30, 2021
@ferBonnin ferBonnin added status: needs author feedback This issue requires additional information from the issue author. status: ready for work This issue is ready to be worked on. labels Apr 30, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

@ghost ghost removed status: ready for work This issue is ready to be worked on. status: needs author feedback This issue requires additional information from the issue author. status: resolved This issue has been merged into main and deployed to canary. labels Apr 30, 2021
@ferBonnin ferBonnin added status: resolved This issue has been merged into main and deployed to canary. status: needs author feedback This issue requires additional information from the issue author. labels Apr 30, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

@ghost ghost added the status: no recent activity This issue requires additional information from the author, but hasn't been updated recently. label May 5, 2021
@ghost
Copy link

ghost commented May 5, 2021

This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for contributing to Accessibility Insights!

@ghost ghost closed this as completed May 8, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working status: needs author feedback This issue requires additional information from the issue author. status: no recent activity This issue requires additional information from the author, but hasn't been updated recently. status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dbjorge @codeofdusk @jalkire @ferBonnin @Bram-diederik