Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Tab stops not showing focused elements #6042

Closed
ThanyaLeif opened this issue Sep 15, 2022 · 2 comments
Closed

[Bug] Tab stops not showing focused elements #6042

ThanyaLeif opened this issue Sep 15, 2022 · 2 comments
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.

Comments

@ThanyaLeif
Copy link
Contributor

Describe the bug

Accessibility Insight Tab stop is not working on MSN. Focused elements should be highlighted, but only a single tab in the middle of the page is marked.

To Reproduce
Steps to reproduce the behavior:

  1. Go to MSN portal
  2. Go to Accessibility Extension > Ad hoc tools
  3. Turn on Tab stops
  4. Navigate throw the page using Tab key
  5. Notice how the focused elements are not marked as tab stops.

Expected behavior

All focused elements should be marked as Tab stops by the extension.

Screenshots

image
Image of a single tab stop shown after Tab stop test.

Context (please complete the following information)

  • AI-Web Version & Environment: Production Version 2.34.1
  • Browser Version: Version 105.0.1343.33 (Official build) (64-bit)
  • Target Page: https://www.msn.com/

Are you willing to submit a PR?

Yes

Did you search for similar existing issues?

Yes

@ThanyaLeif ThanyaLeif added the bug Something isn't working label Sep 15, 2022
@ghost ghost added the status: new This issue is new and requires triage by DRI. label Sep 15, 2022
@ghost ghost assigned ThanyaLeif Sep 15, 2022
@ThanyaLeif ThanyaLeif added the status: needs author feedback This issue requires additional information from the issue author. label Sep 16, 2022
@ghost ghost removed the status: new This issue is new and requires triage by DRI. label Sep 16, 2022
@ghost
Copy link

ghost commented Sep 16, 2022

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

@ghost ghost added status: needs attention The author has provided additional feedback and now requires attention. and removed status: needs author feedback This issue requires additional information from the issue author. labels Sep 16, 2022
@ThanyaLeif
Copy link
Contributor Author

After further investigation, we believe that the cause of the problem is msn.com's implementation of fluent user interface web components. Most of the buttons are located inside closed shadow doms. Accessibility Insighst can only scan open shadow doms, here is a link with more information about it:
https://accessibilityinsights.io/docs/web/reference/faq/#are-automated-checks-compatible-with-shadow-dom

@DaveTryon DaveTryon added status: resolved This issue has been merged into main and deployed to canary. and removed status: needs attention The author has provided additional feedback and now requires attention. labels Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Development

No branches or pull requests

2 participants