From 760f8f1ad293aabcd93e8959c6810f60f75a158d Mon Sep 17 00:00:00 2001 From: Bill Dengler Date: Fri, 18 Aug 2023 19:28:16 -0700 Subject: [PATCH 1/5] Update tab stop instructions everywhere --- src/DetailsView/components/adhoc-tab-stops-test-view.tsx | 2 +- src/content/adhoc/tabstops/how-to-test.tsx | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/DetailsView/components/adhoc-tab-stops-test-view.tsx b/src/DetailsView/components/adhoc-tab-stops-test-view.tsx index dc51e6b3487..b0f243631dc 100644 --- a/src/DetailsView/components/adhoc-tab-stops-test-view.tsx +++ b/src/DetailsView/components/adhoc-tab-stops-test-view.tsx @@ -84,7 +84,7 @@ export const AdhocTabStopsTestView = NamedFC(
  1. Use your keyboard to move input focus through all the interactive elements - in the page-- + on the page –{' '} please traverse the entire page before returning to this window diff --git a/src/content/adhoc/tabstops/how-to-test.tsx b/src/content/adhoc/tabstops/how-to-test.tsx index 5e027f6cd55..2e7bd72ca54 100644 --- a/src/content/adhoc/tabstops/how-to-test.tsx +++ b/src/content/adhoc/tabstops/how-to-test.tsx @@ -16,7 +16,8 @@ export const createHowToTest = (headingLevel: number) => {
  2. Refresh the target page to put it in its default state.
  3. Turn on the Show tab stops toggle. An empty circle will highlight the element with focus.
  4. - Use your keyboard to move input focus through all the interactive elements in the page: + Use your keyboard to move input focus through all the interactive elements on the page –{' '} + please traverse the entire page before returning to this window
    • Use Tab and Shift+Tab to navigate between standalone controls.
    • Use the arrow keys to navigate between the focusable elements within a composite control.
      • From c52d240342a77b75ed3973571010334e51ded20e Mon Sep 17 00:00:00 2001 From: Bill Dengler Date: Fri, 18 Aug 2023 19:28:26 -0700 Subject: [PATCH 2/5] Update test snapshots via automation --- .../__snapshots__/adhoc-tab-stops-test-view.test.tsx.snap | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/tests/unit/tests/DetailsView/components/__snapshots__/adhoc-tab-stops-test-view.test.tsx.snap b/src/tests/unit/tests/DetailsView/components/__snapshots__/adhoc-tab-stops-test-view.test.tsx.snap index 479ef9bd5aa..7a355abc93e 100644 --- a/src/tests/unit/tests/DetailsView/components/__snapshots__/adhoc-tab-stops-test-view.test.tsx.snap +++ b/src/tests/unit/tests/DetailsView/components/__snapshots__/adhoc-tab-stops-test-view.test.tsx.snap @@ -35,7 +35,8 @@ exports[`AdhocTabStopsTestView render handles guidance 1`] = `

      1. - Use your keyboard to move input focus through all the interactive elements in the page-- + Use your keyboard to move input focus through all the interactive elements on the page – + please traverse the entire page before returning to this window @@ -175,7 +176,8 @@ exports[`AdhocTabStopsTestView render handles no guidance 1`] = `

        1. - Use your keyboard to move input focus through all the interactive elements in the page-- + Use your keyboard to move input focus through all the interactive elements on the page – + please traverse the entire page before returning to this window From 6e46b38b2219d20e321057d146126d93b00ca574 Mon Sep 17 00:00:00 2001 From: Bill Dengler Date: Sun, 20 Aug 2023 20:38:27 -0700 Subject: [PATCH 3/5] Update guidance snapshots via automation --- .../content/__snapshots__/guidance-content.test.ts.snap | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap b/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap index ee110d36c19..e8ec31b1037 100644 --- a/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap +++ b/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap @@ -1195,7 +1195,10 @@ exports[`Guidance Content pages adhoc/tabstops/guidance matches the snapshot 1`] Turn on the Show tab stops toggle. An empty circle will highlight the element with focus.
        2. - Use your keyboard to move input focus through all the interactive elements in the page: + Use your keyboard to move input focus through all the interactive elements on the page – + + please traverse the entire page before returning to this window +
          • Use Tab and Shift+Tab to navigate between standalone controls. From 016cc5c6b002d14c65e27d1fa326a1e4a902b948 Mon Sep 17 00:00:00 2001 From: Bill Dengler Date: Mon, 21 Aug 2023 11:03:53 -0700 Subject: [PATCH 4/5] Back out changes to ad hoc tool Signed-off-by: Bill Dengler --- src/content/adhoc/tabstops/how-to-test.tsx | 3 +-- .../content/__snapshots__/guidance-content.test.ts.snap | 5 +---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/content/adhoc/tabstops/how-to-test.tsx b/src/content/adhoc/tabstops/how-to-test.tsx index 2e7bd72ca54..5e027f6cd55 100644 --- a/src/content/adhoc/tabstops/how-to-test.tsx +++ b/src/content/adhoc/tabstops/how-to-test.tsx @@ -16,8 +16,7 @@ export const createHowToTest = (headingLevel: number) => {
          • Refresh the target page to put it in its default state.
          • Turn on the Show tab stops toggle. An empty circle will highlight the element with focus.
          • - Use your keyboard to move input focus through all the interactive elements on the page –{' '} - please traverse the entire page before returning to this window + Use your keyboard to move input focus through all the interactive elements in the page:
            • Use Tab and Shift+Tab to navigate between standalone controls.
            • Use the arrow keys to navigate between the focusable elements within a composite control.
              • diff --git a/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap b/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap index e8ec31b1037..ee110d36c19 100644 --- a/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap +++ b/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap @@ -1195,10 +1195,7 @@ exports[`Guidance Content pages adhoc/tabstops/guidance matches the snapshot 1`] Turn on the Show tab stops toggle. An empty circle will highlight the element with focus.
            • - Use your keyboard to move input focus through all the interactive elements on the page – - - please traverse the entire page before returning to this window - + Use your keyboard to move input focus through all the interactive elements in the page:
              • Use Tab and Shift+Tab to navigate between standalone controls. From 71d9ca75259814545dffe6fc31f83a390f8d57ad Mon Sep 17 00:00:00 2001 From: Bill Dengler Date: Mon, 21 Aug 2023 11:22:32 -0700 Subject: [PATCH 5/5] in/on --- src/content/adhoc/tabstops/how-to-test.tsx | 2 +- .../tests/content/__snapshots__/guidance-content.test.ts.snap | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/content/adhoc/tabstops/how-to-test.tsx b/src/content/adhoc/tabstops/how-to-test.tsx index 5e027f6cd55..ed663567716 100644 --- a/src/content/adhoc/tabstops/how-to-test.tsx +++ b/src/content/adhoc/tabstops/how-to-test.tsx @@ -16,7 +16,7 @@ export const createHowToTest = (headingLevel: number) => {
              • Refresh the target page to put it in its default state.
              • Turn on the Show tab stops toggle. An empty circle will highlight the element with focus.
              • - Use your keyboard to move input focus through all the interactive elements in the page: + Use your keyboard to move input focus through all the interactive elements on the page:
                • Use Tab and Shift+Tab to navigate between standalone controls.
                • Use the arrow keys to navigate between the focusable elements within a composite control.
                  • diff --git a/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap b/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap index ee110d36c19..0699dc91b81 100644 --- a/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap +++ b/src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap @@ -1195,7 +1195,7 @@ exports[`Guidance Content pages adhoc/tabstops/guidance matches the snapshot 1`] Turn on the Show tab stops toggle. An empty circle will highlight the element with focus.
                • - Use your keyboard to move input focus through all the interactive elements in the page: + Use your keyboard to move input focus through all the interactive elements on the page:
                  • Use Tab and Shift+Tab to navigate between standalone controls.