Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create KeyVault backed variable group due to typing issues #58

Closed
nmiodice opened this issue Apr 27, 2020 · 3 comments · Fixed by #72
Closed

Unable to create KeyVault backed variable group due to typing issues #58

nmiodice opened this issue Apr 27, 2020 · 3 comments · Fixed by #72
Labels
bug Something isn't working

Comments

@nmiodice
Copy link

nmiodice commented Apr 27, 2020

When creating a KeyVault, we need to work with the following struct. I'm showing an abridged version here:

type VariableGroup struct {
	Name *string
	ProviderData *VariableGroupProviderData
	Variables *map[string]VariableValue
}

For most variable groups there is no problem. However, when creating a KeyVault backed variable group, the strict typing can become a challenge. There are 2 issues:

The lack of inheritence in Go requires the generated code to produce a VariableGroup that looks more like the following:

type VariableGroup struct {
	Name *string
	ProviderData interface{} // Maybe  pointer? Not sure...
	Variables map[string]interface{}  // Maybe  pointer? Not sure...
}

Note: We will need to be able to have this data in POST API calls as well as returned by the GET API call.

@nmiodice
Copy link
Author

cc @EliiseS

@nmiodice
Copy link
Author

@tedchamb
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants