Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-azure-blobs #4802

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR fixes the new ESLint errors and warnings after upgrading the ESLint packages in the botbuilder-azure-blobs project.

Specific Changes

  • Removed 'botbuilder-azure-blobs/eslint.config.cjs' file as it contained only the 'only-warn' plugin which was no longer needed.
  • Applied the auto-fix flag for all the issues (spacing and trailing commas).

Testing

The following images show the number of issues fixed in the library.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner November 29, 2024 12:03
@coveralls
Copy link

coveralls commented Nov 29, 2024

Pull Request Test Coverage Report for Build 12084402482

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.691%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-azure-blobs/src/blobsStorage.ts 0 1 0.0%
libraries/botbuilder-azure-blobs/src/blobsTranscriptStore.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 12051547941: 0.0%
Covered Lines: 20517
Relevant Lines: 23070

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 925a2c6 into main Dec 3, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botbuilder-azure-blobs branch December 3, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants