Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-dialogs-adaptive-runtime #4810

Merged

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR fixes the new ESLint errors and warnings after upgrading the ESLint packages in the botbuilder-dialogs-adaptive-runtime project.

Specific Changes

  • Removed the 'only-warnings' plugin from botbuilder-dialogs-adaptive-runtime/eslint.config.cjs' file and the related dependency.
  • Applied the auto fix flag for most issues (trailing commas and removal of unnecessary eslint exceptions).
  • Applied manual fixes for new rules like 'import/no-named-as-default-member'.

Testing

The following images show the number of issues fixed in the library and the tests passing after the changes.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner December 10, 2024 14:13
@coveralls
Copy link

coveralls commented Dec 10, 2024

Pull Request Test Coverage Report for Build 12257946172

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.686%

Totals Coverage Status
Change from base Build 12241620968: 0.0%
Covered Lines: 20528
Relevant Lines: 23085

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 7bbb868 into main Dec 10, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botbuilder-dialogs-adaptive-runtime branch December 10, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants