Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode interface should warn if configuration wouldn't permit to stop in a breakpoint #572

Closed
pauloneves opened this issue Mar 25, 2021 · 3 comments

Comments

@pauloneves
Copy link

pauloneves commented Mar 25, 2021

I created an issue because VSCode wouldn't stop in a breakpoint. The problem was that it was configured to stop just in my code and the breakpoint was inside my library. The tests were in a file outside my library.

It would have been nice if VSCode interface showed me that it couldn't stop in the breakpoint. Maybe displaying a notification when I tried to create it. Maybe displaying as disabled.

It also would be nice if it told me that I should have set "justMyCode": Falsein the launch.json

@fabioz
Copy link
Collaborator

fabioz commented Mar 25, 2021

The notification and visibility on that should be done by VSCode itself (debugpy does what it should given the protocol: specify that the breakpoint is disabled with a message giving the details... I haven't checked it now, but from what I remember the breakpoint should appear disabled in this case and when you hover over it, it shows the related message).

@karthiknadig @int19h what do you think? Should debugpy do anything differently here?

@int19h
Copy link
Contributor

int19h commented Mar 25, 2021

If we're already reporting the breakpoint as disabled, but it doesn't show up as such in UI, that sounds like a VSCode (not even extension) bug.

@fabioz
Copy link
Collaborator

fabioz commented Mar 26, 2021

It seems it shows the breakpoint disabled in the editor but not in the breakpoint panel:

image

Anyways, I'm closing the issue here as this is really up to VSCode, not debugpy (so, if you feel this could be better, please create an issue in the VSCode repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants