Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]: GitHub Token isn't created for WinGet Package Submissions #1307

Closed
mdanish-kh opened this issue Jul 19, 2023 · 2 comments
Closed

[CI]: GitHub Token isn't created for WinGet Package Submissions #1307

mdanish-kh opened this issue Jul 19, 2023 · 2 comments
Labels
Issue-Bug Something isn't working or needs investigation Resolution-Fix-Available Available in a release
Milestone

Comments

@mdanish-kh
Copy link
Contributor

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

Take a look at the CI run: https://github.com/microsoft/devhome/actions/runs/5601484465/jobs/10245701244

winget-create fails with error Option 't, token' has no value.. This suggests that a token named WINGET_PAT defined in .github/workflows/winget-submission.yml wasn't added as a repository secret.

- name: Submit package to Windows Package Manager Community Repository
run: |
$packageId = "Microsoft.DevHome"
$gitToken = "${{ secrets.WINGET_PAT }}"

Instructions on creating the classic token can be found over at the winget-create repo. This should be added as a repository secret here in the DevHome repo. I'm not entirely sure but I think @cinnamon-msft is the best candidate for the creation of this token as she publishes the GitHub releases (could be wrong on this one tho).

Expected result

WINGET_PAT repository secret to be referenced properly for the CI

Actual result

CI failing as it could not find the token

Included System Information

No response

Included Extensions Information

No response

@mdanish-kh mdanish-kh added the Issue-Bug Something isn't working or needs investigation label Jul 19, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Jul 19, 2023
@vineeththomasalex
Copy link
Contributor

The above issue has been fixed as suggested.

Adding this new problem with the run to this issue, rather than creating a new issue:
https://github.com/microsoft/devhome/actions/runs/5601484465/jobs/10247807816

"The number of new installer packages must match the number of existing installer packages."
This was expected to be fixed with the latest winget-create. The team is looking into it, and will close this issue after that has been fixed.

@vineeththomasalex
Copy link
Contributor

The above problem was fixed with microsoft/winget-create#411 in Winget-create v1.2.8.0

https://github.com/microsoft/devhome/actions/runs/5601484465/jobs/10251950868
Latest run worked. Closing this issue.

@krschau krschau added this to the Dev Home v0.4 milestone Aug 1, 2023
@krschau krschau added Resolution-Fix-Available Available in a release and removed Needs-Triage New issue that the core contributors need to triage labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working or needs investigation Resolution-Fix-Available Available in a release
Projects
None yet
Development

No branches or pull requests

3 participants