From 701bcd9d150486b4749102ecbe3b51424f7146f7 Mon Sep 17 00:00:00 2001 From: Jesse Parsons <42682358+JesseParsons@users.noreply.github.com> Date: Mon, 16 Sep 2024 11:47:17 -0700 Subject: [PATCH 1/4] Update actions/upload-artifact to v4 --- .github/workflows/E2E integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/E2E integration.yml b/.github/workflows/E2E integration.yml index 79cda1b..87a5726 100644 --- a/.github/workflows/E2E integration.yml +++ b/.github/workflows/E2E integration.yml @@ -81,7 +81,7 @@ jobs: continue-on-error: true - name: Upload eslint results as artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 with: name: eslint-result path: ${{env.PROJECT}}/eslint-result-${{ matrix.os }}-${{github.run_id}}.sarif From 191ff7adb370dac1837906c4695332f85141227e Mon Sep 17 00:00:00 2001 From: Jesse Parsons <42682358+JesseParsons@users.noreply.github.com> Date: Mon, 16 Sep 2024 12:20:09 -0700 Subject: [PATCH 2/4] Add missed change from #43 --- .github/workflows/E2E integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/E2E integration.yml b/.github/workflows/E2E integration.yml index 87a5726..f20d2ba 100644 --- a/.github/workflows/E2E integration.yml +++ b/.github/workflows/E2E integration.yml @@ -6,7 +6,7 @@ name: E2E integration on: push: branches: [main] - pull_request_target: + pull_request: branches: [main, release/vNext] env: From ec3b080f8fbf5520aee981764815bba5e5c8b919 Mon Sep 17 00:00:00 2001 From: Jesse Parsons <42682358+JesseParsons@users.noreply.github.com> Date: Mon, 16 Sep 2024 12:44:18 -0700 Subject: [PATCH 3/4] Explicit version --- .github/workflows/E2E integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/E2E integration.yml b/.github/workflows/E2E integration.yml index f20d2ba..e9a1d2e 100644 --- a/.github/workflows/E2E integration.yml +++ b/.github/workflows/E2E integration.yml @@ -69,7 +69,7 @@ jobs: if: runner.os == 'Windows' - name: Run eslint - run: npx eslint + run: npx eslint@7.32.0 -c node_modules/@microsoft/eslint-plugin-sdl/config/required.js ../${{env.PROJECT}}/${{env.FOLDER_TO_SCAN}}/ --ext .js From 9de9d2a9fc56ddb73a82ca6e1cfea2cf41076579 Mon Sep 17 00:00:00 2001 From: Jesse Parsons <42682358+JesseParsons@users.noreply.github.com> Date: Mon, 16 Sep 2024 15:39:43 -0700 Subject: [PATCH 4/4] Unique name --- .github/workflows/E2E integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/E2E integration.yml b/.github/workflows/E2E integration.yml index e9a1d2e..3778534 100644 --- a/.github/workflows/E2E integration.yml +++ b/.github/workflows/E2E integration.yml @@ -83,6 +83,6 @@ jobs: - name: Upload eslint results as artifact uses: actions/upload-artifact@v4 with: - name: eslint-result + name: eslint-result-${{ matrix.os }} path: ${{env.PROJECT}}/eslint-result-${{ matrix.os }}-${{github.run_id}}.sarif if-no-files-found: error