Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChoiceGroup checked option is not reflected in the input markup #13061

Closed
onlyann opened this issue May 8, 2020 · 1 comment
Closed

ChoiceGroup checked option is not reflected in the input markup #13061

onlyann opened this issue May 8, 2020 · 1 comment
Assignees

Comments

@onlyann
Copy link
Contributor

onlyann commented May 8, 2020

Environment Information

  • Package version(s): 7.110.4

Please provide a reproduction of the bug in a codepen:

The ChoiceGroup basic sample exhibits the issue:
https://codepen.io/onlyann/pen/GRpxrLw

Actual behavior:

Whenever a different option is selected, the initially selected `option remains checked

<input id="ChoiceGroup1-B" class="ms-ChoiceField-input input-48" type="radio" name="ChoiceGroup1" required="" checked="">

whereas the newly selected option is not marked as checked

This doesn't impact the selected option in React.

Expected behavior:

The checked attribute should reflect the currently selected option.

Priorities and help requested:

Are you willing to submit a PR to fix? Yes (if I can identify the root cause)

Requested priority: Low

@onlyann
Copy link
Contributor Author

onlyann commented May 8, 2020

After more research, it looks like this is not an issue with fluent-ui.
React is not necessarily syncing DOM attributes and properties and there is even an attempt through facebook/react#11896 to stop syncing value too.

@onlyann onlyann closed this as completed May 8, 2020
@microsoft microsoft locked as resolved and limited conversation to collaborators Jun 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants