Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using managed identity when using Azure Page Blobs #558

Open
Meir017 opened this issue Aug 5, 2024 · 2 comments · May be fixed by #590
Open

Allow using managed identity when using Azure Page Blobs #558

Meir017 opened this issue Aug 5, 2024 · 2 comments · May be fixed by #590
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Meir017
Copy link
Contributor

Meir017 commented Aug 5, 2024

Feature request type

enhancement

Is your feature request related to a problem? Please describe

Using a ManagedIdentity instead of a connection-string is more secure when interacting with Azure resources.

see https://learn.microsoft.com/en-us/azure/storage/blobs/authorize-access-azure-active-directory#access-data-with-a-microsoft-entra-account

Describe the solution you'd like

Introduce a new options of "storage-managed-identity" that will be the managed-identity id.

Describe alternatives you've considered

No response

Additional context

No response

@TalZaccai TalZaccai self-assigned this Aug 6, 2024
@badrishc
Copy link
Contributor

badrishc commented Aug 6, 2024

Hi @Meir017, thanks for raising this issue. It is a good point -- we need to update AzureStorageDevice to use managed-identity. Thanks for raising it. Would this be of interest for you to contribute a PR towards?

Specifically, AzureStorageDevice takes a connection string here:

It would need to be updated to use managed identity instead, and wire up that property into our configuration:

@Meir017
Copy link
Contributor Author

Meir017 commented Aug 7, 2024

@badrishc I'm not sure I'll be able to get to this in a timely manner, I hope to contribute in the future once I'm more familiar with the codebase

@darrenge darrenge added the enhancement New feature or request label Aug 8, 2024
@badrishc badrishc added the help wanted Extra attention is needed label Aug 9, 2024
@Meir017 Meir017 linked a pull request Aug 14, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants