Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baseUrl set on request adapter is overwritten by generated client constructor #1443

Closed
Tracked by #25
, #1049
...
darrelmiller opened this issue Mar 23, 2022 · 1 comment · Fixed by #1467
Closed
Tracked by #25
, #1049
...

baseUrl set on request adapter is overwritten by generated client constructor #1443

darrelmiller opened this issue Mar 23, 2022 · 1 comment · Fixed by #1467
Assignees
@baywet
Labels
fixed generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Milestone
Community Preview

Comments

@darrelmiller
Copy link
Member

Generated client should only set baseUrl if it is empty.
@darrelmiller darrelmiller added the type:bug A broken experience label Mar 23, 2022
@darrelmiller darrelmiller changed the title baseUrl set on request adapter is overwritten by generated client baseUrl set on request adapter is overwritten by generated client constructor Mar 23, 2022
@baywet baywet added the generator Issues or improvements relater to generation capabilities. label Mar 23, 2022
@baywet baywet added this to Kiota Mar 23, 2022
@baywet baywet added this to the Community Preview milestone Mar 23, 2022
@baywet baywet moved this to Todo in Kiota Mar 23, 2022
@baywet baywet moved this from Todo to In Progress in Kiota Mar 29, 2022
baywet added a commit that referenced this issue Mar 30, 2022
@baywet
- fixes #1443 a bug where the client would reset the base url if prev…
1a99526 
…iously set
@baywet baywet mentioned this issue Mar 30, 2022
Merged
@baywet
Copy link
Member

baywet commented Mar 30, 2022

thanks for reporting this, authored #1467 to address this issue for C#/TS/Java/Go/CLI, and will create corresponding issues for Python/PHP

@baywet baywet added the fixed label Mar 30, 2022
This was referenced Mar 30, 2022
Closed
Closed
Closed
Open
Repository owner moved this from In Progress to Done in Kiota Mar 31, 2022
baywet added a commit that referenced this issue Mar 31, 2022
@baywet
Merge pull request #1467 from microsoft/bugfix/base-url
3733d8d 
- fixes #1443 a bug where the client would reset the base url if previously set
@baywet baywet mentioned this issue Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
fixed generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Projects
Kiota
Archived in project
Milestone
Community Preview
Development

Successfully merging a pull request may close this issue.

- fixes #1443 a bug where the client would reset the base url if previously set microsoft/kiota
2 participants
@darrelmiller @baywet