Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept header should be defined based on the description information #1607

Closed
Tracked by #25 ...
baywet opened this issue Jun 2, 2022 · 0 comments · Fixed by #1615
Closed
Tracked by #25 ...

accept header should be defined based on the description information #1607

baywet opened this issue Jun 2, 2022 · 0 comments · Fixed by #1615
Assignees
Labels
fixed generator Issues or improvements relater to generation capabilities. type:bug A broken experience

Comments

@baywet
Copy link
Member

baywet commented Jun 2, 2022

The description contains the mime/media type of the response. But the description is not necessarily exhaustive, nor is that media type necessarily the default one the service returns.
It is possible that a description contains application/json, but the default response type of the service is application/xml, thus derailing the whole deserialization.
Kiota should read the response media type from the description and include it in the generated code. If multiple media types are present, the should be appended according to the RFC: application/json, application/xml etc...

@baywet baywet added type:bug A broken experience generator Issues or improvements relater to generation capabilities. labels Jun 2, 2022
@baywet baywet self-assigned this Jun 2, 2022
@baywet baywet added this to Kiota Jun 2, 2022
@baywet baywet moved this to Todo in Kiota Jun 2, 2022
@baywet baywet moved this from Todo to In Progress in Kiota Jun 3, 2022
@baywet baywet mentioned this issue Jun 3, 2022
@baywet baywet added the fixed label Jun 3, 2022
Repository owner moved this from In Progress to Done in Kiota Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant