-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
observability of kiota clients #618
Comments
Thanks for logging this one. This is something I had put on ice for a while. We could also provide a logging middleware with the default http core implementation. But it feels like giving people a gun to shoot themselves in the foot with. This could easily lead to logged tokens, or personal information, logs which could be compromised as we've seen in the past. I do think we should seriously consider open telemetry |
Yes https://opentelemetry.io/ is what we should be looking at. We should also follow the Azure SDK logging policies https://azure.github.io/azure-sdk/general_azurecore.html#logging-policy unless we have good reason not to. Ideally we want people to be able to reuse this OpenTelemetry exporter for Azure Monitor https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/README.md |
Thanks for this additional precision. Where would you have logging implemented? Abstractions? http? auth? serialization? all of them? |
Abstractions - I don't think so. |
spec in progress microsoftgraph/msgraph-sdk-design#72 |
AB#11127
The text was updated successfully, but these errors were encountered: