-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/paging #1572
Feat/paging #1572
Conversation
# Conflicts: # src/Kiota.Builder/KiotaBuilder.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first draft!
Beside the comment I left, please fix the failing tests and add an entry to the changelog.
Also thank you for setting the friendly assembly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming into this without context....
Is it correct to call this OpenApi paging as this looks like Microsoft Graph paging coming from a custom attribute?
How do we enable arbitrary paging support for unknown API paging mechanism?
Looks like deltalink is missing as well.
@MIchaelMainer, what is deltalink? This was designed to mirror the autorest extension Autorest x-ms-pageable |
@MIchaelMainer the delta link is a mechanism of sync, not paging. By definition when your application gets a delta link, it's done paging the current changes with the next link, and needs to persist it and come back with it later. I don't think this applies to the scope of these changes. |
@baywet Delta query is a sync mechanism. The deltalink can be an end artifact of a nextlink driven paged result set that was started with a delta query. A deltalink can also be used to make a request that results in a paged result set that is driven by nextlink. I do agree that it is outside the scope of x-ms-pageable and this PR. |
cli/commons/src/Microsoft.Kiota.Cli.Commons.Tests/IO/ODataPagingServiceTest.cs
Outdated
Show resolved
Hide resolved
cli/commons/src/Microsoft.Kiota.Cli.Commons.Tests/IO/ODataPagingServiceTest.cs
Outdated
Show resolved
Hide resolved
cli/commons/src/Microsoft.Kiota.Cli.Commons/IO/ODataPagingService.cs
Outdated
Show resolved
Hide resolved
cli/commons/src/Microsoft.Kiota.Cli.Commons/IO/ODataPagingService.cs
Outdated
Show resolved
Hide resolved
cli/commons/src/Microsoft.Kiota.Cli.Commons/IO/ODataPagingService.cs
Outdated
Show resolved
Hide resolved
cli/commons/src/Microsoft.Kiota.Cli.Commons/IO/ODataPagingService.cs
Outdated
Show resolved
Hide resolved
cli/commons/src/Microsoft.Kiota.Cli.Commons/IO/ODataPagingService.cs
Outdated
Show resolved
Hide resolved
cli/commons/src/Microsoft.Kiota.Cli.Commons/IO/ODataPagingService.cs
Outdated
Show resolved
Hide resolved
This reverts commit 1878cd5.
* Update System.CommandLine to beta 4 Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Kudos, SonarCloud Quality Gate passed! |
Closes #1569