From 7a5d8376e2c525c87cf34b98bc211dc4eaeb45dd Mon Sep 17 00:00:00 2001 From: Jiashuo Li Date: Fri, 22 Jan 2021 21:45:49 +0800 Subject: [PATCH] CLILogging.configure returns as early as possible --- knack/log.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/knack/log.py b/knack/log.py index b26840c..5426f18 100644 --- a/knack/log.py +++ b/knack/log.py @@ -126,11 +126,16 @@ def configure(self, args): :param args: The arguments from the command line :type args: list """ + root_logger = logging.getLogger() + + if root_logger.handlers: + # handlers already configured + return + self.log_level = self._determine_log_level(args) console_log_levels = self._get_console_log_levels() console_log_formats = self._get_console_log_formats() - root_logger = logging.getLogger() # Set the levels of the loggers to lowest level. # Handlers can override by choosing a higher level. root_logger.setLevel(logging.DEBUG) @@ -140,9 +145,6 @@ def configure(self, args): cli_logger.setLevel(logging.DEBUG) cli_logger.propagate = False - if root_logger.handlers: - # handlers already configured - return self._init_console_handlers(root_logger, cli_loggers, console_log_levels, console_log_formats) if self.file_log_enabled: self._init_logfile_handlers(root_logger, cli_loggers)