Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new package in a monorepo without running yarn to link causes a crash #735

Open
dzearing opened this issue Apr 19, 2024 · 3 comments

Comments

@dzearing
Copy link
Member

Describe the bug

Running yarn lage build in a repo root with new packages that haven't yet been symlinked cause lage to throw:

D:\git\pgo-bundling-tools>yarn ci
VERB:  Running with 15 workers
thread '<unnamed>' panicked at 'Failed to read file: Failed to read file', src\hasher.rs:87:48
stack backtrace:
   0:     0x7ffbd7dc7d45 - napi_register_module_v1
   1:     0x7ffbd7cc773b - <unknown>
   2:     0x7ffbd7dba7b1 - napi_register_module_v1
   3:     0x7ffbd7dca24b - napi_register_module_v1
   4:     0x7ffbd7dc9e07 - napi_register_module_v1
   5:     0x7ffbd7dcadbb - napi_register_module_v1
   6:     0x7ffbd7dca7f6 - napi_register_module_v1
   7:     0x7ffbd7dca749 - napi_register_module_v1
   8:     0x7ffbd7dca734 - napi_register_module_v1
   9:     0x7ffbd7dce255 - napi_register_module_v1
  10:     0x7ffbd7dce5b6 - napi_register_module_v1
  11:     0x7ffbd7cd60c4 - <unknown>
  12:     0x7ffbd7ce4475 - <unknown>
  13:     0x7ffbd7ddaae6 - napi_register_module_v1
  14:     0x7ffbd7ce9e46 - <unknown>
  15:     0x7ffbd7cd5d04 - <unknown>
  16:     0x7ffbd7ce9d6c - <unknown>
  17:     0x7ffbd7cd5d04 - <unknown>
  18:     0x7ffbd7ce4475 - <unknown>
  19:     0x7ffbd7ddaae6 - napi_register_module_v1
  20:     0x7ffbd7d49510 - napi_register_module_v1
  21:     0x7ffbd7d481fc - napi_register_module_v1
  22:     0x7ffbd7dc714b - napi_register_module_v1
  23:     0x7ffc3243257d - BaseThreadInitThunk
  24:     0x7ffc3382aa48 - RtlUserThreadStart

To Reproduce

  1. Go to a monorepo where lage usually runs.
  2. Add a package "foo" with a build script.
  3. Change an existing package's dependency list to include "foo"
  4. Run yarn lage build from root.

Expected behavior
Fails to find "foo" and reports it gracefully without a full rust panic.

@romansme
Copy link

romansme commented May 5, 2024

anything on this? happens also out of the blue on an existing project, without doing much

@kenotron
Copy link
Member

kenotron commented May 8, 2024

I fixed this in 2.7.15!!

@kenotron
Copy link
Member

kenotron commented May 8, 2024

btw, git is a requirement, so we do need .git folder to be there in order for lage to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants