Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the indexer be part of a language server or a standalone tool #6

Closed
dbaeumer opened this issue Dec 4, 2018 · 3 comments
Closed
Labels
discussion A issue under discussion

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Dec 4, 2018

Or both.

@dbaeumer dbaeumer added the discussion A issue under discussion label Dec 4, 2018
@dbaeumer dbaeumer changed the title Should the indexer be part of a language server or a standalone tool? Should the indexer be part of a language server or a standalone tool Dec 4, 2018
@DanTup
Copy link

DanTup commented Jan 30, 2019

@dbaeumer Slightly related - When is the tool expected to run and where will the index be stored?

I think in a demo video it was shown that GH PRs in Code could be navigated using LSIF data without having the language extension installed locally. Where is the LSIF data in that case coming from? It seems unlikely that a user would build an LSIF index and commit it in their repo with their pull request.

(I ask here, because I think where it's being run and by who may influence the answer to this question)

@dbaeumer
Copy link
Member Author

@DanTup sorry for the late answer. I think this depends on what you want to do with the dump. We have now tooling to import it into a local SQLite DB and browser it basically offline. So this use case is for local. For things in GitHub it will very likely run in the CLI pipeline.

@dbaeumer
Copy link
Member Author

We collect good experiences with having this as a standalone tool. Java and others went down the same path. I would keep it that way for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion A issue under discussion
Projects
None yet
Development

No branches or pull requests

2 participants