Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentDialog Input not working for TextBox #3804

Closed
JanRajnoha opened this issue Dec 7, 2020 · 19 comments
Closed

ContentDialog Input not working for TextBox #3804

JanRajnoha opened this issue Dec 7, 2020 · 19 comments
Labels
area-Dialogs area-Islands Xaml Islands feature needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) team-Controls Issue for the Controls team

Comments

@JanRajnoha
Copy link

Describe the bug
I tried create ContentDialog with input like TextBox or PasswordBox, but text input is not working. CheckBox (like in sample gallery) is okay. Shortcuts are okay and deleting chars (backspace or delete) is okay too. Content of ContentDialog is created as User Control (from WinUI 3) and testing it as Control in page is its behavior ok too. Is this behavior intentional?

Steps to reproduce the bug
ContentDialog with TextBox (or PasswordBox).

Actual behavior
Input from keyboard not working, Ctrl+V is okay, backspace is okay too.

Version Info

  • Tested sample from WinUI 3 branch sample gallery.

Sample gallery version: 1.2.16.0

Windows 10 version: 20211
Settings of project

  • Min. version: 17763
  • Target version: 18362
@JanRajnoha
Copy link
Author

And type application is Packaged app.

@JanRajnoha
Copy link
Author

@stmoy

@YuliKl
Copy link

YuliKl commented Dec 14, 2020

Sounds like a bug with WinUI 3 controls, not a problem in Xaml Controls Gallery app. Moving repos.

@YuliKl YuliKl transferred this issue from microsoft/WinUI-Gallery Dec 14, 2020
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Dec 14, 2020
@stmoy
Copy link
Contributor

stmoy commented Dec 14, 2020

I think there's still an issue in the XCG which needs to update the ContentDialog page to use XamlRoot. I wonder if this is a symptom of that.

@JanRajnoha
Copy link
Author

Xaml root is not problem. I reported bug about it, but this is new. I assign into property button, which worked okay, everything was okay, but when I try text input, nothing.

@stmoy
Copy link
Contributor

stmoy commented Dec 14, 2020

Thanks for clarifying @JanRajnoha - in that case, I agree with @YuliKl that it sounds like this might be a platform issue.

@StephenLPeters StephenLPeters added area-Dialogs needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Dec 15, 2020
@StephenLPeters
Copy link
Contributor

@JanRajnoha do you know if this issue is unique to Winui3 or if its present in system xaml as well?

@StephenLPeters StephenLPeters added needs-author-feedback Asked author to supply more information. product-winui3 WinUI 3 issues and removed needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) labels Dec 15, 2020
@mdtauk
Copy link
Contributor

mdtauk commented Dec 15, 2020

This may be related to an issue that Windows Terminal has found
microsoft/terminal#8403 (comment)

@DHowett
Copy link
Member

DHowett commented Dec 15, 2020

Thanks for the link-up @mdtauk! Yeah, this is impacting us on system islands.

@JanRajnoha
Copy link
Author

@StephenLPeters ContentDialog with text input works fine in UWP and I suppose it is same bug which @mdtauk wrote.

@ghost ghost added needs-triage Issue needs to be triaged by the area owners and removed needs-author-feedback Asked author to supply more information. labels Dec 15, 2020
@DHowett
Copy link
Member

DHowett commented Dec 16, 2020

@StephenLPeters Yeah -- Terminal is an app using system Xaml (Islands) that has the same issue.

@YuliKl YuliKl added the area-Islands Xaml Islands feature label Dec 16, 2020
@StephenLPeters StephenLPeters added needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) and removed product-winui3 WinUI 3 issues needs-triage Issue needs to be triaged by the area owners labels Dec 17, 2020
@StephenLPeters
Copy link
Contributor

@DHowett a fix to this issue would require system xaml changes and wouldn't go down level, thus I've marked the issue as needs-winui-3 to be addressed after winui3 is shipped. Has Terminal team found a work around that we can post back here?

@DHowett
Copy link
Member

DHowett commented Dec 17, 2020

No. The workaround we've chosen is to not use ContentDialogs.

@JanRajnoha
Copy link
Author

Okay, but I think this problem will be more Serious after releasing version ready for production apps, so avoiding to use it is not good idea. 😕🤔

@JanRajnoha
Copy link
Author

Input is working again, closing issue

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 29, 2021
@DHowett
Copy link
Member

DHowett commented Mar 29, 2021

I believe someone on the team should reopen this. It's still an issue on system Xaml Islands, and it will be an issue forever. It should only be closed when WinUI3 hits GA 😄

@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Mar 30, 2021
@StephenLPeters
Copy link
Contributor

Right now we have a very very high bar for moving fixes back into system xaml. I don't think this will meet that bar, and since it is fixed in winui3 I'm going to keep this closed.

@ShortDevelopment
Copy link

This bug can be fixes for System-Xaml / Xaml-Islands by attaching a ITextInputProducer to the CoreWindow.

https://github.com/ShortDevelopment/ShortDev.Uwp.FullTrust/blob/e2b3df75c499716f7cc586c1793426a2bee34377/ShortDev.Uwp.FullTrust/ShortDev.Uwp.FullTrust/Activation/CoreWindowActivator.cs#L104-L116

Warning
This is a private API that may change at any time!

@aquinn39
Copy link

aquinn39 commented Jun 15, 2023

Right now we have a very very high bar for moving fixes back into system xaml. I don't think this will meet that bar, and since it is fixed in winui3 I'm going to keep this closed.

@StephenLPeters I noticed that the new WinUI 2 XAML Islands based Notepad does not have this issue in the Go To ContentDialog yet the issue still remains in Windows. Does anyone knows how the Notepad developers were able to fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Dialogs area-Islands Xaml Islands feature needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

8 participants