-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++/WinRT] Can't declare a string in Page.Resources with x:Name set #4437
Labels
area-XamlCompiler
bug
Something isn't working
product-winui3
WinUI 3 issues
team-Markup
Issue for the Markup team
Comments
StephenLPeters
added
area-XamlCompiler
needs-winui-3
Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3)
team-Markup
Issue for the Markup team
labels
Mar 9, 2021
evelynwu-msft
added
bug
Something isn't working
and removed
needs-triage
Issue needs to be triaged by the area owners
labels
Jul 21, 2021
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
microsoft-github-policy-service
bot
added
the
needs-triage
Issue needs to be triaged by the area owners
label
Feb 29, 2024
bpulliam
added
product-winui3
WinUI 3 issues
and removed
needs-winui-3
Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3)
needs-triage
Issue needs to be triaged by the area owners
no-issue-activity
labels
Feb 29, 2024
Hi, does this repro in WinAppSDK / WinUI3? Thanks! |
Yes, it does. |
microsoft-github-policy-service
bot
added
needs-triage
Issue needs to be triaged by the area owners
and removed
needs-author-feedback
Asked author to supply more information.
labels
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-XamlCompiler
bug
Something isn't working
product-winui3
WinUI 3 issues
team-Markup
Issue for the Markup team
Describe the bug
In C++/WinRT, you can't set a name for a string inside Page.Resources/UserControl.Resources/ContentDialog.Resource as the XAML compiler generates invalid code for the getter and setter. It uses winrt::System::String as the type for x:String in XAML markup instead winrt::hstring which is the right one.
Steps to reproduce the bug
Steps to reproduce the behavior:
Expected behavior
XAML compiler will generate the correct getter and setter for string values.
Screenshots
Version Info
Package version: WinUI 2.6.0-prerelease.210217002
Visual Studio version: 16.9.0
Windows version: 20H2 Build 19042.804
NuGet package version:
Windows app type:
The text was updated successfully, but these errors were encountered: